Skip to content

[#1191][FOLLOWUP] improvement(conf): use the unified name for hybrid storage in conf - #1350

Merged
zuston merged 1 commit into
apache:masterfrom
zuston:minor-fix
Dec 6, 2023
Merged

[#1191][FOLLOWUP] improvement(conf): use the unified name for hybrid storage in conf#1350
zuston merged 1 commit into
apache:masterfrom
zuston:minor-fix

Conversation

@zuston

@zuston zuston commented Dec 6, 2023

Copy link
Copy Markdown
Member

What changes were proposed in this pull request?

use the unified name for hybrid storage in conf

Why are the changes needed?

Fix: #1191

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Needn't

@codecov-commenter

codecov-commenter commented Dec 6, 2023

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f57360f) 0.00% compared to head (d958bef) 54.18%.

Additional details and impacted files
@@              Coverage Diff              @@
##             master    #1350       +/-   ##
=============================================
+ Coverage          0   54.18%   +54.18%     
- Complexity        0     2712     +2712     
=============================================
  Files             0      398      +398     
  Lines             0    21542    +21542     
  Branches          0     2042     +2042     
=============================================
+ Hits              0    11672    +11672     
- Misses            0     9156     +9156     
- Partials          0      714      +714     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@roryqi roryqi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @zuston

@zuston

zuston commented Dec 6, 2023

Copy link
Copy Markdown
Member Author

Thanks for your review @jerqi . Merged

@zuston
zuston merged commit 0479ca7 into apache:master Dec 6, 2023
zuston added a commit to zuston/incubator-uniffle that referenced this pull request Jan 18, 2024
…ybrid storage in conf (apache#1350)

### What changes were proposed in this pull request?

use the unified name for hybrid storage in conf

### Why are the changes needed?

Fix: apache#1191 

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

Needn't
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants