[MINOR] improvement: use mvn wrapper in CI builds. - #1351
Merged
Conversation
This change will (hopefully) invoke `./mvnw` (wrapper) instead `mvn` command in CI builds, making the local development builds and CI builds equivalent in terms of applied `maven` version.
lukhar
commented
Dec 6, 2023
| @@ -84,11 +84,11 @@ jobs: | |||
| restore-keys: | | |||
| mvn-${{ inputs.java-version }}-package-${{ matrix.profile }}- | |||
Contributor
Author
There was a problem hiding this comment.
It does not seem to me that this one needs to change, having said that I'm rather new to github workflows so any advice on this would be appreciated.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1351 +/- ##
=============================================
+ Coverage 0 54.17% +54.17%
- Complexity 0 2712 +2712
=============================================
Files 0 398 +398
Lines 0 21540 +21540
Branches 0 2042 +2042
=============================================
+ Hits 0 11670 +11670
- Misses 0 9156 +9156
- Partials 0 714 +714 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This is a follow-up to eef0134. The change will (hopefully) invoke
./mvnw(wrapper) instead of themvncommand in CI builds, making the local development builds and CI builds equivalent to the appliedmavenversion.Why are the changes needed?
It's prudent to have the development builds as close to the ones executed by CI/CD system as possible.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
I believe having a PR builder pass should suffice.