Skip to content

[MINOR] Specify name for dataTransferPool - #1353

Merged
zuston merged 3 commits into
apache:masterfrom
wForget:dev
Dec 7, 2023
Merged

[MINOR] Specify name for dataTransferPool#1353
zuston merged 3 commits into
apache:masterfrom
wForget:dev

Conversation

@wForget

@wForget wForget commented Dec 7, 2023

Copy link
Copy Markdown
Member

What changes were proposed in this pull request?

Specify name for dataTransferPool

Why are the changes needed?

dataTransferPool thread pool did not specify name.

image

Does this PR introduce any user-facing change?

No.

How was this patch tested?

minor fix

@codecov-commenter

codecov-commenter commented Dec 7, 2023

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1c7c40b) 53.27% compared to head (51301c2) 54.19%.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1353      +/-   ##
============================================
+ Coverage     53.27%   54.19%   +0.91%     
- Complexity     2712     2713       +1     
============================================
  Files           418      398      -20     
  Lines         23903    21544    -2359     
  Branches       2042     2042              
============================================
- Hits          12734    11675    -1059     
+ Misses        10384     9156    -1228     
+ Partials        785      713      -72     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zuston zuston left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @wForget

@zuston
zuston merged commit c5be58f into apache:master Dec 7, 2023
zuston pushed a commit to zuston/incubator-uniffle that referenced this pull request Jan 18, 2024
…ache#1353)

### What changes were proposed in this pull request?

Specify name for dataTransferPool

### Why are the changes needed?

`dataTransferPool` thread pool did not specify name.

![image](https://github.com/apache/incubator-uniffle/assets/17894939/3baca266-f95b-4af0-a613-a2aa582c8e2b)

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

minor fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants