[#1335] fix(server)(netty): release bytebuf explicitly when requiredId is expired and cache failed - #1357
Merged
Merged
Conversation
…uiredId is expired and cache failed
3 tasks
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1357 +/- ##
============================================
+ Coverage 53.27% 54.18% +0.90%
Complexity 2712 2712
============================================
Files 418 398 -20
Lines 23905 21552 -2353
Branches 2042 2043 +1
============================================
- Hits 12736 11677 -1059
+ Misses 10384 9161 -1223
+ Partials 785 714 -71 ☔ View full report in Codecov by Sentry. |
Member
Author
|
Could you help review this? @jerqi @leixm |
Contributor
|
Nice catch! |
Contributor
|
+1 LGTM. |
Member
Author
Could you help using the review approval, that I could merge this ? |
leixm
approved these changes
Dec 8, 2023
Contributor
Sure. |
Member
Author
|
Thanks @leixm for your review. Merged |
Member
|
@zuston I can't cherry-pick this pr into branch-0.8. Could you create a pr for branch-0.8? |
Member
Author
Ok . |
zuston
added a commit
to zuston/incubator-uniffle
that referenced
this pull request
Dec 13, 2023
…tebuf explicitly when requiredId is expired and cache failed apache#1357
xianjingfeng
pushed a commit
that referenced
this pull request
Dec 14, 2023
…iredId is expired and cache failed #1357 (#1371) ### What changes were proposed in this pull request? Release bytebuf explicitly when requiredId is expired and cache failure occurs ### Why are the changes needed? Fix: #1335 ### Does this PR introduce any user-facing change? No. ### How was this patch tested? Internal production tests.
3 tasks
zuston
added a commit
to zuston/incubator-uniffle
that referenced
this pull request
Jan 18, 2024
…uiredId is expired or cache failed (apache#1357) ### What changes were proposed in this pull request? Release bytebuf explicitly when `requiredId` is expired and cache failure occurs ### Why are the changes needed? Fix: apache#1335 ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Internal production tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Release bytebuf explicitly when
requiredIdis expired and cache failure occursWhy are the changes needed?
Fix: #1335
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Internal production tests.