[#1361] feat(netty): add netty metrics into reporter - #1362
Merged
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1362 +/- ##
============================================
+ Coverage 53.27% 54.16% +0.89%
Complexity 2712 2712
============================================
Files 418 398 -20
Lines 23913 21553 -2360
Branches 2043 2043
============================================
- Hits 12739 11674 -1065
+ Misses 10388 9165 -1223
+ Partials 786 714 -72 ☔ View full report in Codecov by Sentry. |
roryqi
reviewed
Dec 8, 2023
| if (metricReporter != null) { | ||
| metricReporter.addCollectorRegistry(ShuffleServerMetrics.getCollectorRegistry()); | ||
| metricReporter.addCollectorRegistry(grpcMetrics.getCollectorRegistry()); | ||
| metricReporter.addCollectorRegistry(nettyMetrics.getCollectorRegistry()); |
Contributor
There was a problem hiding this comment.
WIll it be null if we don't enable Netty?
Member
Author
There was a problem hiding this comment.
It won't be null, the nettyMetrics always will be initialized.
roryqi
approved these changes
Dec 8, 2023
zuston
added a commit
to zuston/incubator-uniffle
that referenced
this pull request
Jan 18, 2024
### What changes were proposed in this pull request? add netty metrics into reporter ### Why are the changes needed? Fix: apache#1361 ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Needn't
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
add netty metrics into reporter
Why are the changes needed?
Fix: #1361
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Needn't