Skip to content

[#1364] feat(client): introduce option to control whether to use local hadoop conf for remote storage by default - #1370

Merged
zuston merged 4 commits into
apache:masterfrom
zuston:clientStorageConf
Dec 18, 2023
Merged

[#1364] feat(client): introduce option to control whether to use local hadoop conf for remote storage by default#1370
zuston merged 4 commits into
apache:masterfrom
zuston:clientStorageConf

Conversation

@zuston

@zuston zuston commented Dec 13, 2023

Copy link
Copy Markdown
Member

What changes were proposed in this pull request?

Introduce the config to control whether to use local hadoop conf for remote storage by default

Why are the changes needed?

I want to deploy one uniffle cluster to serve for spark jobs in multiple hadoop clusters. So I hope the remote storage config could be loaded from the default hdfs-site.xml in the classpath.

Does this PR introduce any user-facing change?

Yes.

How was this patch tested?

Internal tests.

…e local hadoop conf for remote storage by default
@codecov-commenter

codecov-commenter commented Dec 13, 2023

Copy link
Copy Markdown

Codecov Report

Attention: 11 lines in your changes are missing coverage. Please review.

Comparison is base (b2fe152) 53.22% compared to head (d4c292b) 54.11%.
Report is 2 commits behind head on master.

Files Patch % Lines
...uniffle/shuffle/manager/RssShuffleManagerBase.java 0.00% 11 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1370      +/-   ##
============================================
+ Coverage     53.22%   54.11%   +0.88%     
+ Complexity     2717     2714       -3     
============================================
  Files           418      398      -20     
  Lines         23934    21576    -2358     
  Branches       2043     2043              
============================================
- Hits          12740    11676    -1064     
+ Misses        10409     9187    -1222     
+ Partials        785      713      -72     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zuston
zuston requested a review from roryqi December 13, 2023 10:20
Comment thread common/src/main/java/org/apache/uniffle/common/config/RssClientConf.java Outdated

@roryqi roryqi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @zuston

@zuston
zuston merged commit ce102ce into apache:master Dec 18, 2023
zuston added a commit to zuston/incubator-uniffle that referenced this pull request Jan 18, 2024
…e local hadoop conf (apache#1370)

### What changes were proposed in this pull request?

Introduce the config to control whether to use local hadoop conf for remote storage by default

### Why are the changes needed?

I want to deploy one uniffle cluster to serve for spark jobs in multiple hadoop clusters. So I hope the remote storage config could be loaded from the default hdfs-site.xml in the classpath.

### Does this PR introduce _any_ user-facing change?

Yes.

### How was this patch tested?

Internal tests.
zuston added a commit that referenced this pull request Mar 18, 2024
### What changes were proposed in this pull request?

Provide the uniffle server deploy guide for those machines without hadoop env.

### Why are the changes needed?

Leveraging from the #1379 and #1370 , we could setup uniffle shuffle-server without hadoop env.
This will simplify the quick start process.

Fix: #1576

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

Existing tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants