[#363] refactor(server): Make the coordinator client managed by CoordinatorClientFactory singleton - #1377
Merged
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1377 +/- ##
============================================
+ Coverage 53.24% 54.10% +0.86%
- Complexity 2716 2719 +3
============================================
Files 419 399 -20
Lines 23961 21633 -2328
Branches 2043 2050 +7
============================================
- Hits 12757 11705 -1052
+ Misses 10418 9209 -1209
+ Partials 786 719 -67 ☔ View full report in Codecov by Sentry. |
roryqi
changed the title
Contributor
Author
|
PTAL @jerqi @zuston |
zuston
pushed a commit
to zuston/incubator-uniffle
that referenced
this pull request
Dec 31, 2023
… by CoordinatorClientFactory singleton (apache#1377) ### What changes were proposed in this pull request? Make the coordinator client managed by CoordinatorClientFactory singleton ### Why are the changes needed? Fix: apache#363 ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? unit test .
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Make the coordinator client managed by CoordinatorClientFactory singleton
Why are the changes needed?
Fix: #363
Does this PR introduce any user-facing change?
No.
How was this patch tested?
unit test .