[#1383] fix(docs): Improve Netty's documentation - #1384
Merged
Conversation
Contributor
Author
|
@zuston @jerqi Please have a look at this. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1384 +/- ##
============================================
+ Coverage 53.22% 54.13% +0.91%
- Complexity 2718 2719 +1
============================================
Files 419 399 -20
Lines 23985 21624 -2361
Branches 2049 2049
============================================
- Hits 12765 11707 -1058
+ Misses 10432 9201 -1231
+ Partials 788 716 -72 ☔ View full report in Codecov by Sentry. |
roryqi
approved these changes
Dec 19, 2023
roryqi
changed the title
3 tasks
zuston
pushed a commit
to zuston/incubator-uniffle
that referenced
this pull request
Jan 18, 2024
### What changes were proposed in this pull request? Improve Netty's documentation. (Add the parameter `rss.rpc.server.type` and change all "Netty" to uppercase.) ### Why are the changes needed? For [apache#1383](apache#1383) ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? No need to be tested.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Improve Netty's documentation. (Add the parameter
rss.rpc.server.typeand change all "Netty" to uppercase.)Why are the changes needed?
For #1383
Does this PR introduce any user-facing change?
No.
How was this patch tested?
No need to be tested.