[#1385] improvement: Improve log4j appender layout pattern

[rickyma]

What changes were proposed in this pull request?

Improve the log4j appender layout pattern, by adding the full logger name and code line number.

Why are the changes needed?

For #1385

Does this PR introduce any user-facing change?

No.

How was this patch tested?

By running the process successfully and check the log4j output.

[rickyma]

PTAL @jerqi

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b7962b1) 53.22% compared to head (731e39f) 54.11%.
Report is 6 commits behind head on master.

Additional details and impacted files

@@             Coverage Diff              @@
##             master    #1386      +/-   ##
============================================
+ Coverage     53.22%   54.11%   +0.89%     
- Complexity     2718     2720       +2     
============================================
  Files           419      399      -20     
  Lines         23985    21633    -2352     
  Branches       2049     2051       +2     
============================================
- Hits          12765    11707    -1058     
+ Misses        10432     9208    -1224     
+ Partials        788      718      -70     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[roryqi]

LGTM. thanks @rickyma

[zuston]

I will -1 for this PR, the line number will drop huge performance. And I don't think the line number is necessary for the log.

[rickyma]

@zuston You're right. I'll remove the line number. Any other suggestions here? Thanks.

[zuston]

Can you give the comparison logs of after and before this patch ? @rickyma

[rickyma]

PTAL @zuston

Before this patch:
[INFO] 2023-12-23 01:09:36,830 main ShuffleServer start - Shuffle server start successfully!

After this patch:
[2023-12-23 01:09:36.830] [main] [INFO] org.apache.uniffle.server.ShuffleServer.start - Shuffle server start successfully!

Also, I think the default MaxFileSize 50MB is too small, wouldn't it be better to set it to maybe 2GB?

[zuston]

Before this patch:
[INFO] 2023-12-23 01:09:36,830 main ShuffleServer start - Shuffle server start successfully!

After this patch:
[2023-12-23 01:09:36.830] [main] [INFO] org.apache.uniffle.server.ShuffleServer.start - Shuffle server start successfully!

I think the original log is enough, too long package name is not necessary that will occupy too much space

Also, I think the default MaxFileSize 50MB is too small, wouldn't it be better to set it to maybe 2GB?

This is OK for me.

[rickyma]

Updated. PTAL @zuston

Before this patch:
[INFO] 2023-12-23 01:09:36,830 main ShuffleServer start - Shuffle server start successfully!
MaxFileSize = 50MB

After this patch:
[2023-12-23 01:09:36.830] [main] [INFO] ShuffleServer.start - Shuffle server start successfully!
MaxFileSize = 2GB

[zuston]

LGTM. Thanks for your contribution @rickyma

[roryqi]

LGTM.