[#1391] fix(server): Direct memory may leak in exceptional scenarios in shuffle server. - #1392
Merged
Merged
Conversation
Contributor
Author
|
PTAL @zuston @jerqi |
…arios in shuffle server.
rickyma
force-pushed
the
potential-mem-leak
branch
from
December 22, 2023 18:37
c59859f to
e4b6d3a
Compare
rickyma
changed the title
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1392 +/- ##
============================================
+ Coverage 53.21% 54.12% +0.90%
- Complexity 2719 2720 +1
============================================
Files 419 399 -20
Lines 23989 21627 -2362
Branches 2050 2051 +1
============================================
- Hits 12766 11705 -1061
+ Misses 10433 9204 -1229
+ Partials 790 718 -72 ☔ View full report in Codecov by Sentry. |
3 tasks
3 tasks
zuston
pushed a commit
to zuston/incubator-uniffle
that referenced
this pull request
Dec 31, 2023
…arios in shuffle server. (apache#1392) ### What changes were proposed in this pull request? Release the direct memory in the finally block to prevent memory leaks. ### Why are the changes needed? For [apache#1391](apache#1391) ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? By running server successfully.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Release the direct memory in the finally block to prevent memory leaks.
Why are the changes needed?
For #1391
Does this PR introduce any user-facing change?
No.
How was this patch tested?
By running server successfully.