[#1024] improvement(tez): Optimize user switch to shuffle mode local/remote. - #1397
Merged
Conversation
lifeSo
marked this pull request as draft
December 27, 2023 07:50
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1397 +/- ##
============================================
+ Coverage 53.23% 54.14% +0.90%
- Complexity 2718 2721 +3
============================================
Files 419 399 -20
Lines 23966 21621 -2345
Branches 2042 2045 +3
============================================
- Hits 12758 11706 -1052
+ Misses 10419 9199 -1220
+ Partials 789 716 -73 ☔ View full report in Codecov by Sentry. |
roryqi
changed the title
roryqi
changed the title
lifeSo
marked this pull request as ready for review
December 29, 2023 00:38
Contributor
|
@zhengchenyu Could you help me review this pr? |
zhengchenyu
reviewed
Jan 2, 2024
lifeSo
force-pushed
the
feature_1024_switch_local_rss
branch
2 times, most recently
from
January 2, 2024 21:02
2b60959 to
3e1ca1b
Compare
lifeSo
force-pushed
the
feature_1024_switch_local_rss
branch
from
January 3, 2024 08:00
4b793e2 to
ef6b4ee
Compare
zhengchenyu
previously approved these changes
Jan 3, 2024
roryqi
reviewed
Jan 3, 2024
lifeSo
force-pushed
the
feature_1024_switch_local_rss
branch
from
January 3, 2024 08:49
5071196 to
4fba995
Compare
roryqi
approved these changes
Jan 3, 2024
roryqi
left a comment
roryqi
left a comment
Contributor
There was a problem hiding this comment.
LGTM. merged to master. thanks @lifeSo @zhengchenyu
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Currently, users need to set the parameter tez.am.launch.launch.cmd-opts to switch between local shuffle and remote shuffle, but this parameter is difficult for users to understand.
We need a simpler and easier to understand parameter，such as tez.shuffle.mode = local/remote
Why are the changes needed?
Fix: #1024
Does this PR introduce any user-facing change?
No.
How was this patch tested?
unit test or cluster prd test