[#825][followup] fix(spark):Fix without returning an exception. - #1402
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1402 +/- ##
============================================
+ Coverage 53.23% 54.14% +0.91%
- Complexity 2718 2720 +2
============================================
Files 419 399 -20
Lines 23966 21605 -2361
Branches 2042 2042
============================================
- Hits 12758 11699 -1059
+ Misses 10419 9190 -1229
+ Partials 789 716 -73 ☔ View full report in Codecov by Sentry. |
roryqi
approved these changes
Dec 28, 2023
zuston
pushed a commit
to zuston/incubator-uniffle
that referenced
this pull request
Dec 31, 2023
apache#1402) ### What changes were proposed in this pull request? Fixes exceptions that do not need to be returned. ### Why are the changes needed? Fix: apache#825 ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Existing UT.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Fixes exceptions that do not need to be returned.
Why are the changes needed?
Fix: #825
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Existing UT.