[#1403] fix(client): RSS client configurations are not working. - #1404
Merged
Conversation
Contributor
Author
|
PTAL @jerqi @zuston |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1404 +/- ##
============================================
+ Coverage 53.24% 54.18% +0.94%
- Complexity 2719 2722 +3
============================================
Files 419 399 -20
Lines 23966 21605 -2361
Branches 2042 2042
============================================
- Hits 12760 11707 -1053
+ Misses 10418 9183 -1235
+ Partials 788 715 -73 ☔ View full report in Codecov by Sentry. |
Contributor
Could you add a ut for this pull request? |
rickyma
force-pushed
the
fix-set-rss-client-config-bugs
branch
from
December 29, 2023 08:27
e9270da to
d44bdfb
Compare
Contributor
Author
Added. PTAL @jerqi |
rickyma
force-pushed
the
fix-set-rss-client-config-bugs
branch
2 times, most recently
from
December 29, 2023 17:44
2e93f5e to
310aa3d
Compare
Contributor
Author
|
@jerqi Can you rerun the CI? I ran the same command locally(mvn package -Dtest=org.apache.uniffle.test.** -Pspark3.0), all tests passed. |
Contributor
|
You should format the code |
rickyma
force-pushed
the
fix-set-rss-client-config-bugs
branch
from
January 2, 2024 03:45
310aa3d to
b921b6f
Compare
roryqi
approved these changes
Jan 2, 2024
Contributor
Author
Got it! Thanks. @jerqi |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Fix a bug that was introduced from #1228.
When the RssConf variable is not null, it gets overridden by a new RssConf, resulting in the loss of existing parameters within RssConf.
Why are the changes needed?
For #1403
Does this PR introduce any user-facing change?
No.
How was this patch tested?
By setting RSS client configs successfully.