Skip to content

[#1407] improvement(rust): Some bug fix and optimization - #1408

Merged
zuston merged 9 commits into
apache:masterfrom
zuston:rust-optimization-for-upstream
Dec 30, 2023
Merged

[#1407] improvement(rust): Some bug fix and optimization#1408
zuston merged 9 commits into
apache:masterfrom
zuston:rust-optimization-for-upstream

Conversation

@zuston

@zuston zuston commented Dec 29, 2023

Copy link
Copy Markdown
Member

What changes were proposed in this pull request?

To improve the rust based server performance and fix some bugs

Why are the changes needed?

  • fix getting blockId failure
  • support unregister/finish shuffle grpc interface explicitly
  • fix the memory reserve when app is deleted
  • fix the buffer ticket reserve when app is deleted.
    • add test cases
    • fix the release bug when the partial data sent failed, the allocated should be released
    • refactor ticket management
  • optimize the lock performance when high concurrency of writing

Fix: #1407

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Existing tests

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (386f795) 53.21% compared to head (d385e06) 54.14%.
Report is 6 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1408      +/-   ##
============================================
+ Coverage     53.21%   54.14%   +0.92%     
  Complexity     2719     2719              
============================================
  Files           419      399      -20     
  Lines         23989    21605    -2384     
  Branches       2050     2042       -8     
============================================
- Hits          12766    11698    -1068     
+ Misses        10433     9190    -1243     
+ Partials        790      717      -73     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@roryqi roryqi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@zuston
zuston merged commit a98412e into apache:master Dec 30, 2023
@zuston
zuston deleted the rust-optimization-for-upstream branch December 31, 2023 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Improvement] Rust based server optimization

3 participants