[#1416] feat(spark): support custom hadoop config in client side - #1417
Merged
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1417 +/- ##
============================================
+ Coverage 53.23% 54.19% +0.95%
- Complexity 2721 2725 +4
============================================
Files 419 399 -20
Lines 23982 21636 -2346
Branches 2045 2048 +3
============================================
- Hits 12768 11725 -1043
+ Misses 10427 9193 -1234
+ Partials 787 718 -69 ☔ View full report in Codecov by Sentry. |
roryqi
approved these changes
Jan 5, 2024
3 tasks
zuston
added a commit
to zuston/incubator-uniffle
that referenced
this pull request
Jan 18, 2024
apache#1417) ### What changes were proposed in this pull request? support custom hadoop config in client side ### Why are the changes needed? It's necessary to support user specify custom hadoop config in client side for remote storage. For apache#1416 ### Does this PR introduce _any_ user-facing change? Yes. The prefix key of `spark.rss.hadoop.*` for Hadoop conf. For Spark like that: `spark.rss.hadoop.fs.defaultFS=hdfs://rbf-x1`, this will be as `fs.defaultFS=hdfs://rbf-x1` for Hadoop storage ### How was this patch tested? UTs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
support custom hadoop config in client side
Why are the changes needed?
It's necessary to support user specify custom hadoop config in client side for remote storage.
For #1416
Does this PR introduce any user-facing change?
Yes.
The prefix key of
spark.rss.hadoop.*for Hadoop conf.For Spark like that:
spark.rss.hadoop.fs.defaultFS=hdfs://rbf-x1,this will be as
fs.defaultFS=hdfs://rbf-x1for Hadoop storageHow was this patch tested?
UTs