[#1119] improvement(client): Explicitly throw BUFFER_LIMIT_OF_HUGE_PARTITION - #1425
Merged
Conversation
Contributor
Author
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1425 +/- ##
============================================
+ Coverage 53.43% 54.23% +0.80%
+ Complexity 2723 2720 -3
============================================
Files 419 402 -17
Lines 23992 21659 -2333
Branches 2046 2043 -3
============================================
- Hits 12820 11747 -1073
+ Misses 10378 9190 -1188
+ Partials 794 722 -72 ☔ View full report in Codecov by Sentry. |
zuston
approved these changes
Jan 8, 2024
|
|
||
| // Add NoBufferForHugePartitionException check | ||
| // and ShuffleServerMetrics.TOTAL_REQUIRE_BUFFER_FAILED_FOR_HUGE_PARTITION metric should be 1 | ||
| String content = TestUtils.httpGet(SHUFFLE_SERVER_METRICS_URL); |
Member
There was a problem hiding this comment.
This is really weird. Maybe we could optimize this in the another PR.
zuston
changed the title
BUFFER_LIMIT_OF_HUGE_PARTITION
zuston
reviewed
Jan 18, 2024
|
|
||
| gaugeIsHealthy = metricsManager.addLabeledGauge(IS_HEALTHY); | ||
| gaugeAllocatedBufferSize = metricsManager.addLabeledGauge(ALLOCATED_BUFFER_SIZE); | ||
| counterExpiredPreAllocatedBufferSizeTotal = |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Explicitly throw
BUFFER_LIMIT_OF_HUGE_PARTITIONinstead ofNO_BUFFERWhy are the changes needed?
Fix: #1119
Does this PR introduce any user-facing change?
No.
How was this patch tested?
unit test