Skip to content

[#1435] improvement: Improve log4j settings to avoid annoying messages - #1436

Merged
zuston merged 1 commit into
apache:masterfrom
rickyma:issue-1435
Jan 12, 2024
Merged

[#1435] improvement: Improve log4j settings to avoid annoying messages#1436
zuston merged 1 commit into
apache:masterfrom
rickyma:issue-1435

Conversation

@rickyma

@rickyma rickyma commented Jan 10, 2024

Copy link
Copy Markdown
Contributor

What changes were proposed in this pull request?

Improve the log4j settings to avoid annoying messages, by adding separate loggers in the log4j.properties file.

Why are the changes needed?

For #1435

Does this PR introduce any user-facing change?

No.

How was this patch tested?

By running the process successfully and check the log4j output.

@rickyma

rickyma commented Jan 10, 2024

Copy link
Copy Markdown
Contributor Author

PTAL @jerqi

@roryqi

roryqi commented Jan 10, 2024

Copy link
Copy Markdown
Contributor

Could you show the difference if we don't have this pr?

@rickyma

rickyma commented Jan 11, 2024

Copy link
Copy Markdown
Contributor Author

Could you show the difference if we don't have this pr?

Useless logs like below will be removed in DEBUG mode and will be controlled individually by loggers:

[2024-01-10 00:52:38.344] [grpc-default-worker-ELG-1-39] [DEBUG] io.grpc.netty.shaded.io.grpc.netty.NettyServerHandler.log - [id: 0xfadd038a, L:/100.10.10.112:19977 - R:/9.22.162.91:49272] INBOUND HEADERS: streamId=35051 headers=GrpcHttp2RequestHeaders[:path: /rss.common.ShuffleServer/requireBuffer, :authority: 100.10.10.112:19977, :method: POST, :scheme: http, te: trailers, content-type: application/grpc, user-agent: grpc-java-netty/1.47.0, grpc-accept-encoding: gzip, grpc-timeout: 59999974u] streamDependency=0 weight=16 exclusive=false padding=0 endStream=false
[2024-01-10 00:52:38.424] [grpc-default-worker-ELG-1-3] [DEBUG] io.grpc.netty.shaded.io.grpc.netty.NettyServerHandler.log - [id: 0x6849ffa2, L:/100.10.10.112:19977 - R:/9.22.152.117:59746] INBOUND HEADERS: streamId=40101 headers=GrpcHttp2RequestHeaders[:path: /rss.common.ShuffleServer/requireBuffer, :authority: 100.10.10.112:19977, :method: POST, :scheme: http, te: trailers, content-type: application/grpc, user-agent: grpc-java-netty/1.47.0, grpc-accept-encoding: gzip, grpc-timeout: 59999943u] streamDependency=0 weight=16 exclusive=false padding=0 endStream=false
[2024-01-10 00:57:38.244] [DataStreamer for file /rss/online/application_1703049085550_1336968_1704812682974/0/25-25/100.10.10.112-19977-17000_0_0.data block BP-473621326-9.23.26.217-1686715582091:blk_1074442373_986592] [DEBUG] org.apache.hadoop.hdfs.DataStreamer.run - stage=DATA_STREAMING, blk_1074442373_986592
[2024-01-10 00:57:38.245] [DataStreamer for file /rss/online/application_1703049085550_1336968_1704812682974/0/25-25/100.10.10.112-19977-17000_0_0.data block BP-473621326-9.23.26.217-1686715582091:blk_1074442373_986592] [DEBUG] org.apache.hadoop.hdfs.DataStreamer.run - blk_1074442373_986592 sending packet seqno: 1048 offsetInBlock: 63093248 lastPacketInBlock: false lastByteOffsetInBlock: 63157760

@jerqi

@rickyma rickyma changed the title [#1435]improvement: Improve log4j settings to avoid annoying messages [#1435] improvement: Improve log4j settings to avoid annoying messages Jan 11, 2024

@roryqi roryqi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@zuston zuston left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@zuston
zuston merged commit c141ca3 into apache:master Jan 12, 2024
@rickyma
rickyma deleted the issue-1435 branch May 5, 2024 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants