[#532] SpotBugs: Fix SC_START_IN_CTOR - #1440
Merged
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1440 +/- ##
============================================
+ Coverage 53.38% 54.29% +0.91%
- Complexity 2729 2730 +1
============================================
Files 422 402 -20
Lines 24046 21687 -2359
Branches 2051 2051
============================================
- Hits 12836 11776 -1060
+ Misses 10412 9184 -1228
+ Partials 798 727 -71 ☔ View full report in Codecov by Sentry. |
lifeSo
force-pushed
the
feature_532_spotbugs_thread
branch
from
January 10, 2024 19:07
d75e6f9 to
40bc36c
Compare
Contributor
Author
|
Fix SC_START_IN_CTOR error from SpotBugs suggestion. @jerqi PTAL
|
zuston
pushed a commit
to zuston/incubator-uniffle
that referenced
this pull request
Jan 18, 2024
### What changes were proposed in this pull request? Fix SC_START_IN_CTOR from SpotBugs suggestion. ### Why are the changes needed? Fix SC_START_IN_CTOR from SpotBugs suggestion. Fix: apache#532 ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? unit tests
3 tasks
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Fix SC_START_IN_CTOR from SpotBugs suggestion.
Why are the changes needed?
Fix SC_START_IN_CTOR from SpotBugs suggestion.
Fix: #532
Does this PR introduce any user-facing change?
No.
How was this patch tested?
unit test