[MINOR] refactor: Avoid unnecessary recursion - #1441
Merged
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1441 +/- ##
============================================
+ Coverage 53.38% 54.29% +0.91%
Complexity 2729 2729
============================================
Files 422 402 -20
Lines 24046 21685 -2361
Branches 2051 2051
============================================
- Hits 12836 11774 -1062
+ Misses 10412 9184 -1228
+ Partials 798 727 -71 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Change the recursion of
ShuffleReadClientImpl.readShuffleBlockDatainto an outerwhile(true)loop. Diff is best compared with whitespaces ignored.Why are the changes needed?
The recursion in
ShuffleReadClientImpl.readShuffleBlockDatais not needed because the existingreturnstatements also terminate the introduced outer loop. The recursion depth is limited by the number of consecutive empty segments.Does this PR introduce any user-facing change?
No.
How was this patch tested?
Not tested.