Skip to content

[#1447] feat(client): Introduce configurations to control default behavior of RPC client - #1448

Merged
zuston merged 1 commit into
apache:masterfrom
rickyma:add-rpc-parameters
Jan 16, 2024
Merged

[#1447] feat(client): Introduce configurations to control default behavior of RPC client#1448
zuston merged 1 commit into
apache:masterfrom
rickyma:add-rpc-parameters

Conversation

@rickyma

@rickyma rickyma commented Jan 13, 2024

Copy link
Copy Markdown
Contributor

What changes were proposed in this pull request?

Introduce two configurations to control the default behavior of the RPC client:

Property Name Default Description
<client_type>.rss.client.rpc.timeout.ms 60000 Timeout in milliseconds for RPC calls.
<client_type>.rss.client.rpc.maxAttempts 3 When we fail to send RPC calls, we will retry for maxAttempts times.

Why are the changes needed?

For #1447

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Manually.

@rickyma

rickyma commented Jan 13, 2024

Copy link
Copy Markdown
Contributor Author

PTAL @jerqi @zuston

@codecov-commenter

codecov-commenter commented Jan 13, 2024

Copy link
Copy Markdown

Codecov Report

Attention: 22 lines in your changes are missing coverage. Please review.

Comparison is base (b43bbd8) 54.15% compared to head (3e185d8) 55.19%.
Report is 2 commits behind head on master.

Files Patch % Lines
...ffle/client/impl/grpc/ShuffleServerGrpcClient.java 0.00% 11 Missing ⚠️
...client/impl/grpc/ShuffleServerGrpcNettyClient.java 0.00% 10 Missing ⚠️
...fle/client/factory/ShuffleServerClientFactory.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1448      +/-   ##
============================================
+ Coverage     54.15%   55.19%   +1.04%     
- Complexity     2773     2776       +3     
============================================
  Files           423      403      -20     
  Lines         24178    21843    -2335     
  Branches       2057     2060       +3     
============================================
- Hits          13094    12057    -1037     
+ Misses        10275     9047    -1228     
+ Partials        809      739      -70     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rickyma
rickyma force-pushed the add-rpc-parameters branch from 8553f12 to d20b8dc Compare January 14, 2024 08:05
roryqi
roryqi previously approved these changes Jan 15, 2024

@roryqi roryqi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @rickyma

@zuston zuston left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. But please fix the test failure.

@rickyma
rickyma force-pushed the add-rpc-parameters branch from 473f615 to 3e185d8 Compare January 15, 2024 12:28
@rickyma
rickyma requested review from roryqi and zuston January 15, 2024 13:01
@rickyma

rickyma commented Jan 15, 2024

Copy link
Copy Markdown
Contributor Author

Done.

@zuston
zuston merged commit fc102f0 into apache:master Jan 16, 2024
@zuston

zuston commented Jan 16, 2024

Copy link
Copy Markdown
Member

Merged. Thanks @rickyma

@rickyma
rickyma deleted the add-rpc-parameters branch May 5, 2024 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants