[#1447] feat(client): Introduce configurations to control default behavior of RPC client - #1448
Merged
Merged
Conversation
Contributor
Author
|
PTAL @jerqi @zuston |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1448 +/- ##
============================================
+ Coverage 54.15% 55.19% +1.04%
- Complexity 2773 2776 +3
============================================
Files 423 403 -20
Lines 24178 21843 -2335
Branches 2057 2060 +3
============================================
- Hits 13094 12057 -1037
+ Misses 10275 9047 -1228
+ Partials 809 739 -70 ☔ View full report in Codecov by Sentry. |
rickyma
force-pushed
the
add-rpc-parameters
branch
from
January 14, 2024 08:05
8553f12 to
d20b8dc
Compare
roryqi
previously approved these changes
Jan 15, 2024
zuston
reviewed
Jan 15, 2024
zuston
left a comment
Member
There was a problem hiding this comment.
LGTM. But please fix the test failure.
rickyma
force-pushed
the
add-rpc-parameters
branch
from
January 15, 2024 12:18
d20b8dc to
473f615
Compare
…lt behavior of RPC client
rickyma
force-pushed
the
add-rpc-parameters
branch
from
January 15, 2024 12:28
473f615 to
3e185d8
Compare
Contributor
Author
|
Done. |
roryqi
approved these changes
Jan 15, 2024
zuston
approved these changes
Jan 16, 2024
Member
|
Merged. Thanks @rickyma |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Introduce two configurations to control the default behavior of the RPC client:
Why are the changes needed?
For #1447
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Manually.