Merged
Conversation
Contributor
|
Hello, thanks for the PR, it looks good to me. Any chance we could add some integration tests for this ? |
Contributor
|
I will merge now but it would be really good to add some integration tests soon. |
asfgit
pushed a commit
that referenced
this pull request
Nov 11, 2020
Co-authored-by: Gilad Weinbach <gweinbach@yotpo.com> (cherry picked from commit 353a4b7)
giladw
pushed a commit
to YotpoLtd/unomi-releases
that referenced
this pull request
Dec 1, 2020
* master: (26 commits) Fix typos & Fix Jenkins files Add branch information in main README UNOMI-400 Update documentation to reflect the latest config changes (apache#221) UNOMI-400 Fix class hierarchy lookup for property condition evaluator (apache#220) Return error to the client when exception is thrown from Elasticsearch impl (apache#202) UNOMI-366: Implement increment interest event type & action (apache#201) UNOMI-400 Refactoring of hardcoded property accessors (apache#218) UNOMI-401 Fix missing base class in SecureFilteringClassLoader (apache#219) UNOMI-399: Provide doc inside the custom.system.properties for scripting allow/forbid mechanism (apache#217) UNOMI-400 Fix typo bug in PropertyConditionEvaluator & improve unit test (apache#216) UNOMI-400 More complete hardcoded property accessor implementation (apache#214) UNOMI-401: correctly set ClassLoader before MVEL script execute (apache#215) UNOMI-399: load allow/forbid script from files instead of configuration property to avoid script code conflicting with property value parsing (apache#213) UNOMI-399: fix the loading of MVEL allowed script pattern from config, and return null during script execution if the script is filtered out (apache#211) Add documentation to new security configuration parameters. Add documentation to new security configuration parameters. Remove eslint & dependencies as it is not used. UNOMI-379_support_addValues (apache#207) feat(geo location condition): add support for getting location path f… (#61) (apache#210) ... # Conflicts: # persistence-elasticsearch/core/src/main/java/org/apache/unomi/persistence/elasticsearch/ElasticSearchPersistenceServiceImpl.java # persistence-elasticsearch/core/src/main/resources/OSGI-INF/blueprint/blueprint.xml # persistence-elasticsearch/core/src/main/resources/org.apache.unomi.persistence.elasticsearch.cfg # services/src/main/java/org/apache/unomi/services/impl/segments/SegmentServiceImpl.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.