Skip to content

UNOMI-400 Fix class hierarchy lookup for property condition evaluator#220

Merged
sergehuber merged 1 commit intomasterfrom
UNOMI-400-class-hierarchy-fix
Nov 19, 2020
Merged

UNOMI-400 Fix class hierarchy lookup for property condition evaluator#220
sergehuber merged 1 commit intomasterfrom
UNOMI-400-class-hierarchy-fix

Conversation

@sergehuber
Copy link
Contributor

In this fix was added:

  • Proper building of class ancestry to find all the property accessors on a class
  • Added unit tests for new ancestry method
  • Fix a bug in the MetadataItemAccessor class that was returning null instead of PROPERTY_NOT_FOUND_MARKER

@sergehuber sergehuber merged commit 7b52f7e into master Nov 19, 2020
@sergehuber sergehuber deleted the UNOMI-400-class-hierarchy-fix branch November 19, 2020 20:31
asfgit pushed a commit that referenced this pull request Nov 19, 2020
asfgit pushed a commit that referenced this pull request Nov 19, 2020
sergehuber pushed a commit to Jahia/unomi that referenced this pull request Nov 19, 2020
@sergehuber sergehuber restored the UNOMI-400-class-hierarchy-fix branch November 19, 2020 20:36
@sergehuber sergehuber deleted the UNOMI-400-class-hierarchy-fix branch November 19, 2020 20:36
giladw pushed a commit to YotpoLtd/unomi-releases that referenced this pull request Dec 1, 2020
* master: (26 commits)
  Fix typos &
  Fix Jenkins files
  Add branch information in main README
  UNOMI-400 Update documentation to reflect the latest config changes (apache#221)
  UNOMI-400 Fix class hierarchy lookup for property condition evaluator (apache#220)
  Return error to the client when exception is thrown from Elasticsearch impl (apache#202)
  UNOMI-366: Implement increment interest event type & action (apache#201)
  UNOMI-400 Refactoring of hardcoded property accessors (apache#218)
  UNOMI-401 Fix missing base class in SecureFilteringClassLoader (apache#219)
  UNOMI-399: Provide doc inside the custom.system.properties for scripting allow/forbid mechanism (apache#217)
  UNOMI-400 Fix typo bug in PropertyConditionEvaluator & improve unit test (apache#216)
  UNOMI-400 More complete hardcoded property accessor implementation (apache#214)
  UNOMI-401: correctly set ClassLoader before MVEL script execute (apache#215)
  UNOMI-399: load allow/forbid script from files instead of configuration property to avoid script code conflicting with property value parsing (apache#213)
  UNOMI-399: fix the loading of MVEL allowed script pattern from config, and return null during script execution if the script is filtered out (apache#211)
  Add documentation to new security configuration parameters.
  Add documentation to new security configuration parameters.
  Remove eslint & dependencies as it is not used.
  UNOMI-379_support_addValues (apache#207)
  feat(geo location condition): add support for getting location path f… (#61) (apache#210)
  ...

# Conflicts:
#	persistence-elasticsearch/core/src/main/java/org/apache/unomi/persistence/elasticsearch/ElasticSearchPersistenceServiceImpl.java
#	persistence-elasticsearch/core/src/main/resources/OSGI-INF/blueprint/blueprint.xml
#	persistence-elasticsearch/core/src/main/resources/org.apache.unomi.persistence.elasticsearch.cfg
#	services/src/main/java/org/apache/unomi/services/impl/segments/SegmentServiceImpl.java
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments