Skip to content

[Unomi-485] invalid comparison operator https://issues.apache.org/jira/browse/UNOMI-485#310

Closed
sagyr wants to merge 136 commits intoapache:masterfrom
YotpoLtd:UNOMI-485_invalid_comparisonOperator
Closed

[Unomi-485] invalid comparison operator https://issues.apache.org/jira/browse/UNOMI-485#310
sagyr wants to merge 136 commits intoapache:masterfrom
YotpoLtd:UNOMI-485_invalid_comparisonOperator

Conversation

@sagyr
Copy link
Copy Markdown

@sagyr sagyr commented May 12, 2021

PR Title format:

[UNOMI-XXX] Pull request title with JIRA reference

Please add a meaningful description for your change here

When building a property condition query, throw exception if comparisonOperator is unrecognised.
https://issues.apache.org/jira/browse/UNOMI-485


Please following this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a JIRA issue filed
    for the change (usually before you start working on it). Trivial changes like typos do not
    require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
  • Format the pull request title like [UNOMI-XXX] - Title of the pull request
  • Provide integration tests for your changes, especially if you are changing the behavior of existing code or adding
    significant new parts of code.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
    Copy the description to the related JIRA issue
  • Run mvn clean install -P integration-tests to make sure basic checks pass. A more thorough check will be
    performed on your pull request automatically.

Trivial changes like typos do not require a JIRA issue (javadoc, project build changes, small doc changes, comments...).

If this is your first contribution, you have to read the Contribution Guidelines

If your pull request is about ~20 lines of code you don't need to sign an Individual Contributor License Agreement
if you are unsure please ask on the developers list.

To make clear that you license your contribution under the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

sergehuber and others added 30 commits May 5, 2020 20:16
(cherry picked from commit bce962e)
- Add new profile to easily deactivate integration and performance tests
- Add SHA512 checksum generation for package

(cherry picked from commit 0b96154)
- Add & fix sample that was not included in the build.

(cherry picked from commit da76c72)
…d MVEL2 scripting languages (apache#158)

* Make it possible to white list and black list classes used in OGNL and MVEL2 scripting languages

* Add new integration test to AllITs list

* Add some documentation for the configuration parameters

(cherry picked from commit 789ae8e)
# Conflicts:
#	.travis.yml
#	buildAndDeployUnomiFromTag.sh
* fix(SetEventOccurenceCountAction.java) - check the event's timestamp before increase the pastEvent counter by 1

* fix(SetEventOccurenceCountAction.java) - change comment to Serge suggestion

* rename(UpdateEventFromContextServletIT) - rename test class to "ContextServletIT"

* improve(ContextServletIT) - refactor existing tests

* improve(ContextServletIT) - delete indexes' CONTENT instead of deleting the indexes

* feat(ContextServletIT) - remove sessions between tests

* improve(TestUtils) - change "executeContextJSONRequest" function to static

* feat(ContextServletIT) - add unit-tests for past-event-segment calculation when adding events with custom timestamp

Co-authored-by: nlevitsky <Pitzek1305>
giladw and others added 29 commits February 17, 2021 13:42
Update segments in profile - via elastic query & script
retry update when failure occurs
Added feature flag
fix persistence service documentation
Optimizations
ES: Add/remove to list script moved to es persistence service
Update by query: configurable slices & batch size
Exec list property update via script
Add configurable slices amount for elastic service
Removed unused props
@sagyr sagyr closed this May 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants