UNOMI-957: Add cross-platform memory sampling for integration test runs#782
Merged
Conversation
Record Karaf, search engine, Docker, and host memory metrics during ./build.sh --integration-tests, summarize peaks for archiving and CI, and auto-generate operator notes tied to each run.
sergehuber
force-pushed
the
UNOMI-957-it-memory-sampling
branch
from
dd5bbba to
5c15522
Compare
…ple line The function-as-variable guards in it_memory_resolve_search_engine and it_memory_read_trace_heap_mb always evaluated false, so OpenSearch IT runs silently sampled the wrong Docker container/port, and the karaf-heap pom fallback never ran. Also fix a printf format string with one more %s placeholder than arguments, which appended a spurious empty trailing column to every memory-samples.tsv row.
Give the synthetic RUNNING task a valid node lock so background recoverCrashedTasks() cannot mark it before preDestroy() runs.
Run purge/load in system tenant context, persist preDestroy test tasks with a lock in a single save, and cancel system tasks before asserting execution count.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
./build.sh --integration-tests(Karaf heap/GCT, search engine heap, Docker RSS, host RAM/swap/load).itests/sample-it-memory.sh(start/stop/summarize/operator-note/verify) anditests/lib/it-run-memory.shwith macOS and Linux collectors.memory-samples.tsv,memory-summary.txt, and auto-generatedit-run-operator-note.txtunderitests/target/.archive-it-run.shand uploads CI artifactit-memory-metrics-*.JIRA
https://issues.apache.org/jira/browse/UNOMI-957
Test plan
cd itests && ./sample-it-memory.sh verify(macOS and Linux)./build.sh --integration-tests— sampler starts/stops; peaks inmemory-summary.txt./build.sh --integration-tests --no-memory-sampler— no sampler artifacts required./archive-it-run.sh— memory files included in captureit-memory-metrics-*artifact present after workflow run