UNOMI-881: Harden GoalsServiceImplTest against CI flakiness#788
Merged
Conversation
Align teardown with RulesServiceImplTest (shutdown event admin, rules service, scheduler), clear execution context between tests, and run nested-condition setup under executeAsSystem so system-tenant condition types resolve reliably in CI.
sergehuber
force-pushed
the
UNOMI-881-goals-test-flake
branch
from
ccc7bf1 to
88d05bf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GoalsServiceImplTest.testSetGoalWithNestedConditions(seen on PR UNOMI-934/935: Return 400 for invalid rule/segment create (Phase 2 PR 4) #787 full./build.sh --cirun; passed on rerun).@AfterEachteardown withRulesServiceImplTest: shut downTestEventAdmin,RulesServiceImpl, scheduler, and detach the rules event listener.ExecutionContextManagerthread-local context between tests to avoid tenant leakage across the Surefire JVM.setGoalunderexecuteAsSystem()so system-tenant condition types resolve reliably; addassertNotNullguards and explicitgoal.setItemId.Context
Unrelated to REST exception mapping (#787). Test-only change; no production code.
Test plan
mvn -pl services test -Dmaven.build.cache.enabled=false -Dtest=GoalsServiceImplTest./build.sh --ci(unit tests)