UNOMI-939/940: Scheduler dispatch and cache refresh race fixes#792
Merged
Conversation
eeb59ee to
2de4368
Compare
Forces saveItem() and refreshTypeCache() to interleave via controlled latches instead of relying on timing-dependent integration tests to occasionally catch a regression in the per-item-type ReadWriteLock.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Plain-language summary
Apache Unomi runs background jobs on a schedule. Examples include cache refresh and maintenance tasks. It also keeps in-memory copies of configuration such as rules and segments.
Under load or during shutdown, several bugs were possible. The same job could run twice. A recurring job could not be stopped at some times. A scheduled cache reload could overwrite data that had just been saved.
This PR fixes these timing bugs. Operators and connected systems should see more stable behavior.
What changed
Scheduler
In-memory caches (rules, segments, definitions, etc.)
Tests
Test plan
mvn -pl :unomi-services,:unomi-services-common,:unomi-tracing-impl -am test(targeted)References
UNOMI-939, UNOMI-940, UNOMI-929