UNOMI-978: Gate cross-profile merge and systemProperties writes on a trusted caller - #854
Open
sergehuber wants to merge 1 commit into
Open
UNOMI-978: Gate cross-profile merge and systemProperties writes on a trusted caller#854sergehuber wants to merge 1 commit into
sergehuber wants to merge 1 commit into
Conversation
Closed
10 tasks
…trusted caller Two built-in actions operate on identity rather than on the calling profile's own data. MergeProfilesOnPropertyAction merges the current profile into another one selected by a property value, and UpdatePropertiesAction can write systemProperties, where trust-bearing state such as merge and identity markers is kept. Deciding that two profiles are the same person, or writing the markers that record it, is a claim about identity, and a claim about identity should come from a caller the server has established as entitled to make it. Both now require a trusted caller, behind a single isTrustedIdentityCaller() seam. Writes to a caller's own properties and same-profile merges are unchanged, and a server-side integration holding the tenant private key keeps both capabilities. A refused attempt is logged through the shared org.apache.unomi.api.utils.LogSanitizer, so a request-derived value cannot break out of its log record. The login sample is rewritten to demonstrate the pattern this leaves in place: the browser posts to the operator's own servlet, which holds the tenant private key and performs the merge server-side, rather than asking the visitor's browser to assert who it is. Integrations that performed the merge from the browser need to move that step behind their own server, which the sample now shows end to end. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
asf-gitbox-commits
force-pushed
the
UNOMI-978-action-identity-ownership
branch
from
August 14, 2026 14:32
cea3929 to
c10e68b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two built-in actions operate on identity rather than on the calling profile's own data.
MergeProfilesOnPropertyAction merges the current profile into another one selected by a property
value, and UpdatePropertiesAction can write systemProperties, where trust-bearing state such as
merge and identity markers is kept. Deciding that two profiles are the same person, or writing the
markers that record it, is a claim about identity, and a claim about identity should come from a
caller the server has established as entitled to make it.
Both now require a trusted caller, behind a single isTrustedIdentityCaller() seam. Writes to a
caller's own properties and same-profile merges are unchanged, and a server-side integration
holding the tenant private key keeps both capabilities.
A refused attempt is logged through the shared org.apache.unomi.api.utils.LogSanitizer, so a
request-derived value cannot break out of its log record.
The login sample is rewritten to demonstrate the pattern this leaves in place: the browser posts to
the operator's own servlet, which holds the tenant private key and performs the merge server-side,
rather than asking the visitor's browser to assert who it is. Integrations that performed the merge
from the browser need to move that step behind their own server, which the sample now shows end to
end.
Jira: https://issues.apache.org/jira/browse/UNOMI-978