Validate file upload resource constraints server-side - #1516
Merged
Conversation
Contributor
|
@M0nd0R thanks for the PR... I will review ASAP and test our app, that uses this functionality, still works. |
reiern70
self-requested a review
July 14, 2026 16:11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This change stops
FileUploadToResourceFieldfrom trusting client-controlled upload limit parameters.Root Cause
The upload resource accepted
maxSize,fileMaxSize, andfileCountMaxdirectly from the request URL. A client could tamper with those values and relax the server-side limits that were rendered by the component.Fix
Render a signed
uploadTokenalongside the configured limits and reject uploads when the submitted limits do not match the signed values.Validation
mvn -pl wicket-core-tests -am -Dtest=org.apache.wicket.markup.html.form.upload.resource.FileUploadToResourceFieldSecurityTest -Dsurefire.failIfNoSpecifiedTests=false clean test