Upgrade build to Ruby 3.3.5, consolidate Dependabot bumps, and remove vendored docs Gemfiles#59
Closed
jongyoul wants to merge 1 commit into
Closed
Upgrade build to Ruby 3.3.5, consolidate Dependabot bumps, and remove vendored docs Gemfiles#59jongyoul wants to merge 1 commit into
jongyoul wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the site’s build/runtime dependencies to unblock builds by moving the Docker-based Jekyll environment to Ruby 3.3.5 and consolidating several Dependabot dependency bumps across the root site, the docs/0.12.0 subsite, and the helium GitHub Action.
Changes:
- Upgraded the Docker build image from Ruby 3.0.6 to Ruby 3.3.5.
- Updated Ruby gem dependencies (notably
nokogiri,addressable,faraday, plus lockfile updates) in the root site anddocs/0.12.0. - Updated transitive npm dependencies for the helium workflow via
package-lock.jsonchanges.
Reviewed changes
Copilot reviewed 3 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
Gemfile |
Pins nokogiri to 1.19.3 for the root site. |
Gemfile.lock |
Updates bundled gems (incl. addressable, faraday, nokogiri) and updates the Bundler version recorded in the lockfile. |
docs/0.12.0/Gemfile |
Pins nokogiri to 1.19.3 for the docs/0.12.0 subsite. |
docs/0.12.0/Gemfile.lock |
Updates nokogiri, addressable, and rexml (lockfile-only dependency changes for docs/0.12.0). |
Dockerfile |
Moves the base image to ruby:3.3.5 for local Docker builds. |
.github/workflows/helium/package-lock.json |
Updates ajv, follow-redirects, and underscore in the helium action lockfile. |
Files not reviewed (1)
- .github/workflows/helium/package-lock.json: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
17
to
21
| gem 'github-pages' | ||
| gem 'redcarpet' | ||
| gem 'jekyll-twitter-plugin' | ||
| gem 'nokogiri', '1.15.4' | ||
| gem 'nokogiri', '1.19.3' | ||
| gem 'mini_portile2', '2.8.4' |
Comment on lines
1
to
3
| # Use the latest official Ruby runtime as a parent image | ||
| FROM ruby:3.0.6 | ||
| FROM ruby:3.3.5 | ||
|
|
…bumps, drop vendored docs Gemfiles Upgrade the Docker build image from ruby:3.0.6 to ruby:3.3.5 and pin Bundler 4.0.13 (matching Gemfile.lock's BUNDLED WITH) so the site builds reproducibly: nokogiri 1.19.3 needs Ruby >= 3.2 and activesupport 7.2.3.1 (already in the lockfile) needs Ruby >= 3.1, so the old ruby:3.0.6 image can no longer build the site. Consolidate the pending Dependabot bumps. Root site (Gemfile / Gemfile.lock): - nokogiri 1.15.4 -> 1.19.3 - faraday 2.14.1 -> 2.14.2 - addressable 2.8.5 -> 2.9.0 helium GitHub Action (npm, lockfileVersion 2 kept): - follow-redirects 1.15.6 -> 1.16.0 - ajv 6.12.6 -> 6.15.0 - underscore 1.13.7 -> 1.13.8 Remove the vendored Gemfile/Gemfile.lock from every docs/<version>/ subfolder. These are build artifacts accidentally copied from the docs build sources (byte-identical to the root Gemfile) and are not used to serve the static site; they were the source of the recurring Dependabot security PRs against docs/. The published static HTML is untouched. Verified with bundle install (Bundler 4.0.13) + jekyll build on Ruby 3.3.5 and npm ci for the helium action, both inside Docker. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
jongyoul
force-pushed
the
update-build-ruby-3.3.5
branch
from
June 6, 2026 06:45
4c789dc to
8c9f430
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR consolidates the 9 open Dependabot PRs into one change and modernizes the build:
nokogiri 1.19.3needs Ruby>= 3.2andactivesupport 7.2.3.1(already pinned in the lockfile) needs>= 3.1, so the oldruby:3.0.6image can no longer build the site.Gemfile.lock'sBUNDLED WITH, for reproducible builds.Gemfile/Gemfile.lockfrom everydocs/<version>/. These are build artifacts that were accidentally copied from the docs build sources (they are byte-identical to the rootGemfile) and are not used to serve the static site — but they are exactly what triggers the recurring Dependabot security PRs againstdocs/.Merging this PR closes all 9 Dependabot PRs automatically (see Closes below).
Changes
Root site (
Gemfile,Gemfile.lock,Dockerfile)ruby:3.0.6→ruby:3.3.54.0.13(matchesBUNDLED WITH)1.15.4→1.19.3(Bump nokogiri from 1.15.4 to 1.19.3 #53)2.14.1→2.14.2(Bump faraday from 2.14.1 to 2.14.2 #57)2.8.5→2.9.0(Bump addressable from 2.8.5 to 2.9.0 #50)docs/ — removed stray build-artifact Gemfiles
Gemfile+Gemfile.lockunder everydocs/<version>/(0.5.0-incubating … 0.12.0)docs/is left untouchedhelium GitHub Action (
package-lock.json,lockfileVersion: 2preserved)1.15.6→1.16.0(Bump follow-redirects from 1.15.6 to 1.16.0 in /.github/workflows/helium #52)6.12.6→6.15.0(Bump ajv from 6.12.6 to 6.14.0 in /.github/workflows/helium #49)1.13.7→1.13.8(Bump underscore from 1.13.7 to 1.13.8 in /.github/workflows/helium #47)Verification
All builds run inside Docker:
bundle install(Bundler 4.0.13) +jekyll buildsucceed on Ruby 3.3.5npm cisucceeds for the helium actionCloses
Closes #57, #53, #50, #54, #51, #33, #52, #49, #47