ZEPPELIN-2486. AngularElem's onChange is only invoked once#2312
Closed
zjffdu wants to merge 1 commit intoapache:masterfrom
Closed
ZEPPELIN-2486. AngularElem's onChange is only invoked once#2312zjffdu wants to merge 1 commit intoapache:masterfrom
zjffdu wants to merge 1 commit intoapache:masterfrom
Conversation
Contributor
Author
|
@Leemoonsoo Please help review. |
Leemoonsoo
reviewed
May 3, 2017
| Text(s"${functionName}=$$event.timeStamp"), | ||
| Null) | ||
| Text(s"${functionName}=${functionName} + 1"), | ||
| Null) % Attribute(None, "ng-init", Text(s"${functionName} = 0"), Null) |
Member
There was a problem hiding this comment.
Looks like initializing value using ng-init calls callback function once, before the actual event.
I think the ${functionName} need to be initialized in the following line
val angularObject = addAngularObject(functionName, 1)
Contributor
Author
There was a problem hiding this comment.
Good catch, PR is updated.
Member
|
LGTM |
Contributor
Author
|
Thanks, will merge if no more comments. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR for?
ng-changecan not capture event, so that means$event.timeStampis undefined. angular/angular.js#6370This cause AngularElem's onChange is only invoked once. This PR use another approach to update the angularObject.
What type of PR is it?
[Bug Fix]
Todos
What is the Jira issue?
How should this be tested?
Tested manually
Screenshots (if appropriate)
Before
After
Questions: