Return the new setting ID in the response call in the REST API#258
Closed
eranwitkon wants to merge 3 commits into
Closed
Return the new setting ID in the response call in the REST API#258eranwitkon wants to merge 3 commits into
eranwitkon wants to merge 3 commits into
Conversation
Author
|
CI failed due to a download problem: Which has nothing to do with my code. |
|
Just remove an empty line in one of your files and push again it will trigger a new build. That file has been failing on my builds too. We should look into the resiliency of the build. |
added 2 commits
August 26, 2015 14:18
Member
|
Looks good to me. |
Author
|
This PR is integrated into PR #266 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes the JSON body of the create setting REST api to return the new created setting ID.
the new return body looks like the following:
The documentation will be updated on a different PR once this is merged.
The unit testing is updated on PR 241 together with other REST API test.
Ready for review