Skip to content

Return the new setting ID in the response call in the REST API#258

Closed
eranwitkon wants to merge 3 commits into
apache:masterfrom
eranwitkon:261
Closed

Return the new setting ID in the response call in the REST API#258
eranwitkon wants to merge 3 commits into
apache:masterfrom
eranwitkon:261

Conversation

@eranwitkon
Copy link
Copy Markdown

This PR changes the JSON body of the create setting REST api to return the new created setting ID.
the new return body looks like the following:

{"status":"CREATED","message":"","body":"2AWGRNYY3"}

The documentation will be updated on a different PR once this is merged.
The unit testing is updated on PR 241 together with other REST API test.
Ready for review

@eranwitkon
Copy link
Copy Markdown
Author

CI failed due to a download problem:
Failed to execute goal com.github.eirslett:frontend-maven-plugin:0.0.23:install-node-and-npm (install node and npm) on project zeppelin-web: Could not download Node.js: Could not download http://nodejs.org/dist/v0.10.18/node-v0.10.18-linux-x64.tar.gz: Connect to nodejs.org:80 [nodejs.org/165.225.133.150] failed: Connection timed out -> [Help 1]

Which has nothing to do with my code.
How do we trigger CI build again?

@djoelz
Copy link
Copy Markdown

djoelz commented Aug 26, 2015

Just remove an empty line in one of your files and push again it will trigger a new build. That file has been failing on my builds too. We should look into the resiliency of the build.

@Leemoonsoo
Copy link
Copy Markdown
Member

Looks good to me.

@eranwitkon
Copy link
Copy Markdown
Author

This PR is integrated into PR #266

@eranwitkon eranwitkon closed this Aug 31, 2015
@eranwitkon eranwitkon deleted the 261 branch September 2, 2015 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants