Zeppelin-272: Remove option part from REST API#266
Closed
eranwitkon wants to merge 6 commits into
Closed
Conversation
added 3 commits
August 30, 2015 14:53
…from response. JsonResponse was updated accordingly to apply this strategy
…UpdatedInterpreterSettingRequest. Updated InterpreterRestAPI to send new InterpreterOption(remote=true) as option to Interpreter factory.
…UpdatedInterpreterSettingRequest. Updated InterpreterRestAPI to send new InterpreterOption(remote=true) as option to Interpreter factory. Rebase with PR apache#261 to return new created settings for REST API
This was referenced Aug 31, 2015
added 2 commits
August 31, 2015 14:43
Author
|
Fixed RAT issue. |
Member
Author
|
I will have a look at this as well although the PR is about the REST API בתאריך יום ג׳, 1 בספט׳ 2015, 20:43 מאת Lee moon soo <
|
Member
|
merging if there're no more discussions |
Leemoonsoo
pushed a commit
to Leemoonsoo/zeppelin
that referenced
this pull request
Sep 17, 2015
This PR remove the option part from the Interpreter setting REST API [x] Remove option from list settings [x] Remove option from Create settings and update settings [X] Update Create setting to return new created setting (jira 261) replacing pr # 258 Remove option from list setting is done by implementing a Exclusion strategy for the gson serialization. Remove option from the Create\Update REST API is done by passing new InterpreterOption(remote=true) the the Factory and by omitting the InterpreterOption from the NewInterpreterSetting and UpdateInterpreterSetting classes. REST API tests are managed in another Update to the documentation will be done in a separate PR Author: eranwitkon <goi.cto@gmail.com> Closes apache#266 from eranwitkon/272 and squashes the following commits: f196a76 [eranwitkon] Remove option setting from Interpreter web page 5ad5e99 [eranwitkon] Add Licensed to the Apache Software Foundation for the new JsonExclusionStrategy class b1ff1aa [eranwitkon] Fix CI error f2178f6 [eranwitkon] Remove InterpreterOption class from NewInterpreterSettingRequest and UpdatedInterpreterSettingRequest. Updated InterpreterRestAPI to send new InterpreterOption(remote=true) as option to Interpreter factory. Rebase with PR apache#261 to return new created settings for REST API 14e8809 [eranwitkon] Remove InterpreterOption class from NewInterpreterSettingRequest and UpdatedInterpreterSettingRequest. Updated InterpreterRestAPI to send new InterpreterOption(remote=true) as option to Interpreter factory. b980069 [eranwitkon] Added exclusion strategy class for gson to exclude InterpreterOption from response. JsonResponse was updated accordingly to apply this strategy (cherry picked from commit 42d9271) Signed-off-by: Lee moon soo <moon@apache.org>
lelou6666
pushed a commit
to lelou6666/incubator-zeppelin
that referenced
this pull request
Mar 25, 2016
Improve pivot chart behavior
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR remove the option part from the Interpreter setting REST API
[x] Remove option from list settings
[x] Remove option from Create settings and update settings
[X] Update Create setting to return new created setting (jira 261) replacing pr # 258
Remove option from list setting is done by implementing a Exclusion strategy for the gson serialization.
Remove option from the Create\Update REST API is done by passing new InterpreterOption(remote=true) the the Factory and by omitting the InterpreterOption from the NewInterpreterSetting and UpdateInterpreterSetting classes.
REST API tests are managed in another
Update to the documentation will be done in a separate PR