ZEPPELIN-181 Provide more Feedback on UI when Clicking the Cancel/Stop Button of a Pending/Running Paragraph#261
Closed
r-kamath wants to merge 4 commits into
Closed
ZEPPELIN-181 Provide more Feedback on UI when Clicking the Cancel/Stop Button of a Pending/Running Paragraph#261r-kamath wants to merge 4 commits into
r-kamath wants to merge 4 commits into
Conversation
…p Button of a Pending/Running Paragraph Changes to be committed: modified: zeppelin-web/src/app/notebook/paragraph/paragraph.controller.js modified: zeppelin-web/src/app/notebook/paragraph/paragraph.html
Contributor
|
Tried on my local, LGTM. |
Member
There was a problem hiding this comment.
perhaps independent from this visual change, not everything is cancel-able from the interpreter? should there be a way to communicate that to the visual?
Contributor
|
I think this should be handled at the Websocket/Backend level. For example, after sending the CANCEL_PARAGRAPH, you will receive the note with paragraph.status as 'ABORT' once it is finished. While you did set the pagraph.status to 'CANCELING', other people visiting the note would see it as 'PENDING' instead of 'CANCELING' |
…ncel/Stop Button of a Pending/Running Paragraph" This reverts commit ff9748f.
Member
Author
|
@corneadoug @felixcheung thanks for the feedback. trying to make some changes in the server side to have CANCELING status. will post my updates here |
…into ZEPPELIN-181
eranwitkon
pushed a commit
to eranwitkon/incubator-zeppelin
that referenced
this pull request
Aug 31, 2015
…UpdatedInterpreterSettingRequest. Updated InterpreterRestAPI to send new InterpreterOption(remote=true) as option to Interpreter factory. Rebase with PR apache#261 to return new created settings for REST API
- cancel paragraph backend call returns status CANCELING
Member
Author
|
@corneadoug let me know if the update is good. Currently the new status
For a complete implementation this status should be used in Scheduler classes as well |
Member
|
It'll broadcast 'CANCELING' event to connected browsers that is seeing the notebook. As you mentioned, for completeness, i think it's better insert |
|
and don't forget your unit tests :) |
asfgit
pushed a commit
that referenced
this pull request
Sep 3, 2015
This PR remove the option part from the Interpreter setting REST API [x] Remove option from list settings [x] Remove option from Create settings and update settings [X] Update Create setting to return new created setting (jira 261) replacing pr # 258 Remove option from list setting is done by implementing a Exclusion strategy for the gson serialization. Remove option from the Create\Update REST API is done by passing new InterpreterOption(remote=true) the the Factory and by omitting the InterpreterOption from the NewInterpreterSetting and UpdateInterpreterSetting classes. REST API tests are managed in another Update to the documentation will be done in a separate PR Author: eranwitkon <goi.cto@gmail.com> Closes #266 from eranwitkon/272 and squashes the following commits: f196a76 [eranwitkon] Remove option setting from Interpreter web page 5ad5e99 [eranwitkon] Add Licensed to the Apache Software Foundation for the new JsonExclusionStrategy class b1ff1aa [eranwitkon] Fix CI error f2178f6 [eranwitkon] Remove InterpreterOption class from NewInterpreterSettingRequest and UpdatedInterpreterSettingRequest. Updated InterpreterRestAPI to send new InterpreterOption(remote=true) as option to Interpreter factory. Rebase with PR #261 to return new created settings for REST API 14e8809 [eranwitkon] Remove InterpreterOption class from NewInterpreterSettingRequest and UpdatedInterpreterSettingRequest. Updated InterpreterRestAPI to send new InterpreterOption(remote=true) as option to Interpreter factory. b980069 [eranwitkon] Added exclusion strategy class for gson to exclude InterpreterOption from response. JsonResponse was updated accordingly to apply this strategy
Member
Author
|
will reopen when the patch is ready |
Leemoonsoo
pushed a commit
to Leemoonsoo/zeppelin
that referenced
this pull request
Sep 17, 2015
This PR remove the option part from the Interpreter setting REST API [x] Remove option from list settings [x] Remove option from Create settings and update settings [X] Update Create setting to return new created setting (jira 261) replacing pr # 258 Remove option from list setting is done by implementing a Exclusion strategy for the gson serialization. Remove option from the Create\Update REST API is done by passing new InterpreterOption(remote=true) the the Factory and by omitting the InterpreterOption from the NewInterpreterSetting and UpdateInterpreterSetting classes. REST API tests are managed in another Update to the documentation will be done in a separate PR Author: eranwitkon <goi.cto@gmail.com> Closes apache#266 from eranwitkon/272 and squashes the following commits: f196a76 [eranwitkon] Remove option setting from Interpreter web page 5ad5e99 [eranwitkon] Add Licensed to the Apache Software Foundation for the new JsonExclusionStrategy class b1ff1aa [eranwitkon] Fix CI error f2178f6 [eranwitkon] Remove InterpreterOption class from NewInterpreterSettingRequest and UpdatedInterpreterSettingRequest. Updated InterpreterRestAPI to send new InterpreterOption(remote=true) as option to Interpreter factory. Rebase with PR apache#261 to return new created settings for REST API 14e8809 [eranwitkon] Remove InterpreterOption class from NewInterpreterSettingRequest and UpdatedInterpreterSettingRequest. Updated InterpreterRestAPI to send new InterpreterOption(remote=true) as option to Interpreter factory. b980069 [eranwitkon] Added exclusion strategy class for gson to exclude InterpreterOption from response. JsonResponse was updated accordingly to apply this strategy (cherry picked from commit 42d9271) Signed-off-by: Lee moon soo <moon@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On branch ZEPPELIN-181
Changes to be committed:
modified: zeppelin-web/src/app/notebook/paragraph/paragraph.controller.js
modified: zeppelin-web/src/app/notebook/paragraph/paragraph.html
screenshot :
