[ZEPPELIN-5169] Hive set statement doesn't work for some hive version when there's empty line ahead - #4005
Closed
zjffdu wants to merge 1 commit into
Closed
[ZEPPELIN-5169] Hive set statement doesn't work for some hive version when there's empty line ahead#4005zjffdu wants to merge 1 commit into
zjffdu wants to merge 1 commit into
Conversation
zjffdu
changed the title
…n when there's empty line ahead
zjffdu
force-pushed
the
ZEPPELIN-5169
branch
from
December 26, 2020 23:28
31b8973 to
b05b063
Compare
asfgit
pushed a commit
that referenced
this pull request
Jan 3, 2021
… when there's empty line ahead ### What is this PR for? The current sql split logic will append empty lines before sql statement, this would cause issues for the sql statement for some hive version. This is to fix it by checking whether it is set statement, if yes, then trim the sql statement. ### What type of PR is it? [ Improvement ] ### Todos * [ ] - Task ### What is the Jira issue? * https://issues.apache.org/jira/browse/ZEPPELIN-5169 ### How should this be tested? * Manually tested ### Screenshots (if appropriate) ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No Author: Jeff Zhang <zjffdu@apache.org> Closes #4005 from zjffdu/ZEPPELIN-5169 and squashes the following commits: b05b063 [Jeff Zhang] [ZEPPELIN-5169]. Hive set statement doesn't work for some hive version when there's empty line ahead (cherry picked from commit e96c244) Signed-off-by: Jeff Zhang <zjffdu@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR for?
The current sql split logic will append empty lines before sql statement, this would cause issues for the sql statement for some hive version. This is to fix it by checking whether it is set statement, if yes, then trim the sql statement.
What type of PR is it?
[ Improvement ]
Todos
What is the Jira issue?
How should this be tested?
Screenshots (if appropriate)
Questions: