Skip to content

[ZEPPELIN-6496] Replace BigQuery polling stdout output with SLF4J logging#5298

Merged
jongyoul merged 1 commit into
apache:masterfrom
celinayk:ZEPPELIN-6496
Jul 14, 2026
Merged

[ZEPPELIN-6496] Replace BigQuery polling stdout output with SLF4J logging#5298
jongyoul merged 1 commit into
apache:masterfrom
celinayk:ZEPPELIN-6496

Conversation

@celinayk

Copy link
Copy Markdown
Contributor

What is this PR for?

BigQueryInterpreter.pollJob(...) printed job polling status directly to standard output via System.out.println(...), bypassing Zeppelin's SLF4J/Log4j2 logging
configuration, log levels, and appenders. This made diagnostics noisy and hard to route in server/interpreter deployments. This PR replaces the direct stdout call with a
structured SLF4J logger call.

What type of PR is it?

Improvement

Todos

  • Replace System.out.println(...) in pollJob(...) with LOGGER.info(...)
  • Preserve job state and wait interval information in the log message
  • No behavior changes to polling, sleeping, or returned job handling

What is the Jira issue?

ZEPPELIN-6496

How should this be tested?

  • rg -n "System\.out\.println|System\.err\.println" bigquery/src/main/java/org/apache/zeppelin/bigquery returns no results
  • ./mvnw test -pl bigquery compiles/builds successfully
  • Manually trigger a BigQuery job poll and confirm the state/interval now appears via the configured logger instead of raw stdout

Screenshots (if appropriate)

N/A

Questions:

  • Does the license files need to update? No
  • Is there breaking changes for older versions? No
  • Does this needs documentation? No

@ParkGyeongTae ParkGyeongTae left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The change correctly replaces the System.out.println in pollJob()
with LOGGER.info(...), which is already declared in the class.

Using SLF4J parameterized logging ({}) is a small additional improvement
over the original string concatenation — it avoids unnecessary string
construction when the INFO level is disabled.

Verified:

  • No remaining System.out/System.err calls in the bigquery package.
  • Polling behavior (while loop, Thread.sleep, returned Job) is unchanged.

Nit: The PR title appears to be truncated — could you update it to
[ZEPPELIN-6496] Replace BigQuery polling stdout output with SLF4J logging?

@ParkGyeongTae ParkGyeongTae self-assigned this Jul 13, 2026

@jongyoul jongyoul left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the current head. The logging-only change preserves BigQuery polling behavior, and the remaining Selenium failure is unrelated to this module.

@celinayk celinayk changed the title [ZEPPELIN-6496] Replace BigQuery polling stdout output with SLF4J log… [ZEPPELIN-6496] Replace BigQuery polling stdout output with SLF4J logging Jul 14, 2026
@celinayk

Copy link
Copy Markdown
Contributor Author

Thanks for the reviews! Updated the PR title to the full form as suggested.

@jongyoul jongyoul merged commit 8b0bf9c into apache:master Jul 14, 2026
18 of 19 checks passed
@jongyoul

Copy link
Copy Markdown
Member

Merged into master (8b0bf9c).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants