Skip to content

[ZEPPELIN-6507] Return empty list from FileInterpreter.completion() #5394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ParkGyeongTae merged 1 commit into from
Aug 9, 2026
+15 −1
Merged

[ZEPPELIN-6507] Return empty list from FileInterpreter.completion() #5394

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion file/src/main/java/org/apache/zeppelin/file/FileInterpreter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@
import java.nio.file.Path;
import java.nio.file.Paths;
import java.util.ArrayList;
import java.util.Collections;
import java.util.HashSet;
import java.util.List;
import java.util.Properties;
Expand Down Expand Up @@ -167,6 +168,6 @@ public Scheduler getScheduler() {
@Override
public List<InterpreterCompletion> completion(String buf, int cursor,
InterpreterContext interpreterContext) {
return null;
return Collections.emptyList();
}
}
13 changes: 13 additions & 0 deletions file/src/test/java/org/apache/zeppelin/file/FileInterpreterTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,12 +19,15 @@
package org.apache.zeppelin.file;

import static org.junit.jupiter.api.Assertions.assertEquals;
import static org.junit.jupiter.api.Assertions.assertNotNull;
import static org.junit.jupiter.api.Assertions.assertTrue;
import static org.junit.jupiter.api.Assertions.assertFalse;

import java.util.List;
import java.util.Properties;

import org.apache.zeppelin.interpreter.InterpreterException;
import org.apache.zeppelin.interpreter.thrift.InterpreterCompletion;
import org.junit.jupiter.api.Test;

/**
Expand Down Expand Up @@ -178,4 +181,14 @@ void testComplexCommand() {
assertTrue(args.flags.contains('h'));
assertFalse(args.flags.contains('-'));
}

@Test
void testCompletionReturnsEmptyListInsteadOfNull() {
TestFileInterpreter interpreter = new TestFileInterpreter(new Properties());

List<InterpreterCompletion> completions = interpreter.completion("ls", 2, null);

assertNotNull(completions, "completion() should never return null");
assertTrue(completions.isEmpty(), "Default completion() should return an empty list");
}
}
Loading