[ZEPPELIN-6660] Add notebook parity registry - #5456
Conversation
|
A few suggestions. 1. Move the schema definition to a declarative form
Adding 2. Playwright tags instead of test titles Putting the identifier in the title and matching it as a substring means routine title cleanups break the registry. Playwright here is 1.55.1, so tags are available: test('should display notebook container with proper structure', { tag: '@NB-PARITY-001' }, async () => {});3. Does the role axis need to be required on every scenario? NB-PARITY-001 and 060 are
4. Duplicated strings that are not identifiers Referencing scenarios by
5. Consistency with
|
What is this PR for?
This PR records the current Angular Notebook behaviour in a reusable parity registry.
The editable source is JSON and the human-readable Markdown table is generated from it. Each scenario has a stable
NB-PARITY-###identifier and links either to an existing Playwright E2E test or to the Jira issue that tracks the remaining work.The validator rejects drift between JSON and generated Markdown, duplicate or invalid scenario identifiers, unsupported coverage states, a
coveredclaim without an executable Playwright test carrying the same identifier, incomplete scenarios without a Jira issue, and invalid evidence or test paths.Existing Notebook Playwright test titles now carry the stable scenario identifiers, and the frontend CI workflow runs the registry check.
This does not implement missing E2E behaviour or claim that React Notebook parity is complete. It establishes the characterization baseline that later Angular, Shared Core, and React work can compare against.
The generated registry and validation approach follows Apache Ambari's React parity matrix work:
What type of PR is it?
Improvement
Todos
What is the Jira issue?
ZEPPELIN-6660
How should this be tested?
cd zeppelin-web-angular npm run check:notebook-parity-scenariosThe command passes after rebasing on the latest
origin/master: 15 validator tests pass and the checked-in registry matches its generated Markdown view.The
quickGitHub Actions workflow has passed. Thefrontendandcoreworkflows are still running for the rebased commit.Screenshots (if appropriate)
N/A
Questions:
notebook-parity.mdis the generated review document for the registry.