ZOOKEEPER-3903: Fix typos and grammar in recipes.md - #1418
Closed
asutosh936 wants to merge 2 commits into
Closed
Conversation
maoling
reviewed
Aug 2, 2020
maoling
left a comment
maoling
left a comment
Member
There was a problem hiding this comment.
@asutosh936
I suggest that you check all the typo issues in this page: recipes.md to make this patch more valuable to get merged. For this, you can use some automated tools for finding typo
Contributor
Author
|
@maoling - Have updated PR with all possible grammar fixes |
nkalmar
reviewed
Aug 6, 2020
| When implementing the recipes you must handle recoverable exceptions | ||
| (see the [FAQ](https://cwiki.apache.org/confluence/display/ZOOKEEPER/FAQ)). In | ||
| particular, several of the recipes employ sequential ephemeral | ||
| (see the [FAQ](https://cwiki.apache.org/confluence/display/ZOOKEEPER/FAQ)). In particular, several of the recipes employ sequential ephemeral |
Contributor
There was a problem hiding this comment.
why merge the 2 lines into 1 long line? In several other places as well. While this document has long line like this, these paragraphs are limited to shorter lines, and I think this brakes that. This is just a nit from me though.
Contributor
Author
There was a problem hiding this comment.
Breaking the lines creates grammatical errors, hence merged 2 lines into 1.
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.