Skip to content

ZOOKEEPER-5066: Update JDK11 to JDK 17, 25 in s390x jenkinsfile#2420

Merged
anmolnar merged 2 commits into
apache:masterfrom
linux-on-ibm-z:s390x-jenkins-fix
Jul 7, 2026
Merged

ZOOKEEPER-5066: Update JDK11 to JDK 17, 25 in s390x jenkinsfile#2420
anmolnar merged 2 commits into
apache:masterfrom
linux-on-ibm-z:s390x-jenkins-fix

Conversation

@shreya-sawant

Copy link
Copy Markdown
Contributor

Since JDK 17 is minimum runtime and compile version for the master branch, update s390x jenkins job to use JDK 17 and also add JDK 25.

@PDavid PDavid left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for noticing this, somehow I overlooked this Jenkinsfile.

Can I ask if the indentation changes are required? Or can they be reverted?

@shreya-sawant

Copy link
Copy Markdown
Contributor Author

Thank you @PDavid for your prompt reply. The indentation changes are required as I've added a matrix {} block to support building against multiple JDK versions (jdk_17_latest and jdk_25_latest). Hence all the inner blocks had to be re-indented.

@PDavid

PDavid commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

Thank you @PDavid for your prompt reply. The indentation changes are required as I've added a matrix {} block to support building against multiple JDK versions (jdk_17_latest and jdk_25_latest). Hence all the inner blocks had to be re-indented.

Thanks for your response @shreya-sawant. 👍 I completely missed the matrix block. Now it makes sense to me. 👌

@PDavid PDavid left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Looks good to me. 👍

@anmolnar anmolnar left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

@anmolnar anmolnar merged commit 8e3527a into apache:master Jul 7, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants