Skip to content

fix: check if the specified backup method exists when creating a backup#328

Merged
d976045024 merged 4 commits intomainfrom
support/backup-method-check
May 7, 2024
Merged

fix: check if the specified backup method exists when creating a backup#328
d976045024 merged 4 commits intomainfrom
support/backup-method-check

Conversation

@d976045024
Copy link
Copy Markdown
Contributor

@d976045024 d976045024 commented May 7, 2024

fix: #326

@github-actions github-actions Bot added the size/S Denotes a PR that changes 10-29 lines. label May 7, 2024
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 7, 2024

Codecov Report

Attention: Patch coverage is 60.00000% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 42.84%. Comparing base (bb707c8) to head (6172d1a).
Report is 2 commits behind head on main.

Files Patch % Lines
pkg/cmd/cluster/dataprotection.go 60.00% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #328   +/-   ##
=======================================
  Coverage   42.84%   42.84%           
=======================================
  Files         213      213           
  Lines       29031    29041   +10     
=======================================
+ Hits        12438    12444    +6     
- Misses      15059    15062    +3     
- Partials     1534     1535    +1     
Flag Coverage Δ
unittests 42.84% <60.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Comment thread pkg/cmd/cluster/dataprotection.go Outdated
@d976045024 d976045024 requested a review from ldming May 7, 2024 07:46
@d976045024 d976045024 merged commit 2c04abc into main May 7, 2024
@d976045024 d976045024 deleted the support/backup-method-check branch May 7, 2024 13:32
@github-actions github-actions Bot added this to the Release 0.9.0 milestone May 7, 2024
@ldming
Copy link
Copy Markdown
Collaborator

ldming commented May 7, 2024

/cherry-pick release-0.9

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 7, 2024

🤖 says: cherry pick action finished successfully 🎉!
See: https://github.com/apecloud/kbcli/actions/runs/8987774524

github-actions Bot pushed a commit that referenced this pull request May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/S Denotes a PR that changes 10-29 lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Improvement] kbcli cluster backup should check if the specified backup method exists

3 participants