Skip to content

fix: check if the specified backup method exists when creating a backup #328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
d976045024 merged 4 commits into from
May 7, 2024
Merged

fix: check if the specified backup method exists when creating a backup #328

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1edfd31
fix: check if the specified backup method exists when creating a back…
d976045024 May 7, 2024
3d5602e
fix: check if the specified backup method exists when creating a back…
d976045024 May 7, 2024
6172d1a
fix: modify msg format (#326)
d976045024 May 7, 2024
b3c6e13
fix: modify msg format (#326)
d976045024 May 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions pkg/cmd/cluster/dataprotection.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,6 +191,21 @@ func (o *CreateBackupOptions) Validate() error {
if o.BackupSpec.BackupMethod == "" {
return fmt.Errorf("backup method can not be empty, you can specify it by --method")
}

// check if the backup method exists in backup policy
exist, availableMethods := false, make([]string, 0)
for _, method := range backupPolicy.Spec.BackupMethods {
availableMethods = append(availableMethods, method.Name)
if o.BackupSpec.BackupMethod == method.Name {
exist = true
break
}
}
if !exist {
return fmt.Errorf("specified backup method %s does not exist in backup policy %s, available methods: [%s]\n",
o.BackupSpec.BackupMethod, backupPolicy.Name, strings.Join(availableMethods, ", "))
}

// TODO: check if pvc exists

// valid retention period
Expand Down