Skip to content

chore: improve controllers apps component coverage - #10380

Merged
leon-ape merged 1 commit into
mainfrom
support/coverage-controllers-apps-component
Jun 16, 2026
Merged

chore: improve controllers apps component coverage#10380
leon-ape merged 1 commit into
mainfrom
support/coverage-controllers-apps-component

Conversation

@leon-ape

Copy link
Copy Markdown
Collaborator

Summary

  • add stable Ginkgo/Gomega coverage for component workload helper edge cases
  • cover host-network allocation, deletion skip, placement annotation, legacy config-manager cleanup decisions, and pod template diff helpers
  • raise controllers/apps/component coverage from 78.1% to 80.4%
  • no production code changes

Tests

  • KUBEBUILDER_ASSETS= GOFLAGS=-mod=mod GOCACHE= go test -short ./controllers/apps/component -coverprofile=
  • GOFLAGS=-mod=mod GOCACHE= go tool cover -func=

@leon-ape leon-ape added the nopick Not auto cherry-pick when PR merged label Jun 15, 2026
@apecloud-bot

Copy link
Copy Markdown
Collaborator

Auto Cherry-pick Instructions

Usage:
  - /nopick: Not auto cherry-pick when PR merged.
  - /pick: release-x.x [release-x.x]: Auto cherry-pick to the specified branch when PR merged.

Example:
  - /nopick
  - /pick release-1.1

CLA Recheck Instructions

Usage:
  - /recheck-cla: Trigger a re-check of CLA status for this pull request.
Example:
  - /recheck-cla

@github-actions github-actions Bot added the size/L Denotes a PR that changes 100-499 lines. label Jun 15, 2026
@codecov

codecov Bot commented Jun 15, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 53.60%. Comparing base (93ec22c) to head (468eefb).
⚠️ Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10380      +/-   ##
==========================================
+ Coverage   53.26%   53.60%   +0.33%     
==========================================
  Files         533      533              
  Lines       63529    63532       +3     
==========================================
+ Hits        33839    34055     +216     
+ Misses      26249    26039     -210     
+ Partials     3441     3438       -3     
Flag Coverage Δ
unittests 53.60% <ø> (+0.33%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@leon-ape
leon-ape marked this pull request as ready for review June 15, 2026 15:29
@leon-ape
leon-ape requested a review from a team as a code owner June 15, 2026 15:29
@leon-ape

Copy link
Copy Markdown
Collaborator Author

/approve

@apecloud-bot apecloud-bot added the approved PR Approved Test label Jun 15, 2026
@leon-ape
leon-ape merged commit 08b33cc into main Jun 16, 2026
45 checks passed
@leon-ape
leon-ape deleted the support/coverage-controllers-apps-component branch June 16, 2026 00:30
@github-actions github-actions Bot added this to the Release 1.2.0 milestone Jun 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved PR Approved Test nopick Not auto cherry-pick when PR merged size/L Denotes a PR that changes 100-499 lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants