fix(operations): validate upgrade service version and fail fast on invalid format - #10470
Merged
Merged
Conversation
Collaborator
|
Auto Cherry-pick Instructions CLA Recheck Instructions |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #10470 +/- ##
==========================================
+ Coverage 62.10% 62.18% +0.07%
==========================================
Files 533 533
Lines 63722 63727 +5
==========================================
+ Hits 39577 39629 +52
+ Misses 20547 20507 -40
+ Partials 3598 3591 -7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
leon-ape
approved these changes
Jun 29, 2026
Collaborator
|
/cherry-pick release-1.1 |
Collaborator
|
🤖 says: cherry pick action finished successfully 🎉! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When OpsRequest upgrade is used with an invalid service version format (e.g.,
"17.5"instead of"17.5.0"), the OpsRequest gets stuck inRunningstatus forever because:validateUpgrade()does not validate theServiceVersionformat, so invalid versions pass initial validationReconcileAction(),version.ParseSemantic()fails but returns a regular (non-fatal) error, causing infinite retry loopsChanges
apis/operations/v1alpha1/opsrequest_validation.goServiceVersionsemver format validation invalidateUpgrade()usingversion.ParseSemantic()"17.5","not-a-version") now fail during validation phasepkg/operations/upgrade.goGetCompDefByName()andUpdateCompDefinitionImages4ServiceVersion()as fatal errors viaintctrlutil.NewFatalError()Failedphase instead of retrying indefinitelyTests
TestValidateUpgradeServiceVersion(11 cases) for the validation functionOpsFailedPhaseFix #10461