fix: align instance api pvc labels with instanceset - #10588
Conversation
|
Auto Cherry-pick Instructions CLA Recheck Instructions |
9014bdf to
fd01deb
Compare
|
/approve |
fd01deb to
0915522
Compare
|
/approve |
0915522 to
d11a9de
Compare
|
/approve |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #10588 +/- ##
==========================================
+ Coverage 63.74% 63.79% +0.05%
==========================================
Files 519 519
Lines 62848 62859 +11
==========================================
+ Hits 40060 40100 +40
+ Misses 19178 19155 -23
+ Partials 3610 3604 -6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
/cherry-pick release-1.1 |
|
🤖 says: Error cherry-picking. |
|
🤖 says: |
What changed
Instance API PVC creation now merges pod template labels into generated PVCs, matching the existing InstanceSet PVC label behavior.
Why
The InstanceSet path adds template labels to PVCs. The InstanceSet2 + Instance API path already applies template labels to the Instance and Pod, but did not carry those labels into PVCs. That made PVCs miss component identity labels such as
app.kubernetes.io/instanceandapps.kubeblocks.io/component-name, so volume expansion progress lookup could not discover them by the existing label selector.This keeps the behavior scoped to template labels and does not copy all Instance object labels to PVCs.
The Instance API PVC identity label
apps.kubeblocks.io/instance-nameremains owned by the Instance controller so deletion/retention reconciliation can still find the PVCs.Fix #10576.
Validation