fix(instanceset): normalize planner role priorities - #10700
Merged
Conversation
Collaborator
|
Auto Cherry-pick Instructions CLA Recheck Instructions |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #10700 +/- ##
==========================================
+ Coverage 63.94% 64.05% +0.11%
==========================================
Files 520 520
Lines 63013 63014 +1
==========================================
+ Hits 40291 40363 +72
+ Misses 19116 19059 -57
+ Partials 3606 3592 -14
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Collaborator
Author
|
/approve |
apecloud-bot
approved these changes
Jul 22, 2026
Collaborator
|
/cherry-pick release-1.1 |
Collaborator
|
🤖 says: cherry pick action finished successfully 🎉! |
apecloud-bot
pushed a commit
that referenced
this pull request
Jul 22, 2026
(cherry picked from commit 9106a97)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
BestEffortParallelquorum layers whenReplicaRole.Nameuses mixed caseWhy
ComposeRolePriorityMapstores role names in lower case, but the BestEffort planner calculated its quorum and leader thresholds with the originalReplicaRole.Name. Names such asFollowerandLeadertherefore resolved to the default priority and could place multiple quorum members in the same update layer.This is the InstanceSet counterpart to #10677.
Validation
go test ./pkg/controller/instanceset -count=1Fixes #10641