fix(workloads): aggregate restore status for instance API - #10831
Merged
Conversation
Collaborator
|
Auto Cherry-pick Instructions CLA Recheck Instructions |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #10831 +/- ##
==========================================
+ Coverage 65.66% 65.80% +0.13%
==========================================
Files 510 510
Lines 64405 64698 +293
==========================================
+ Hits 42294 42573 +279
- Misses 18360 18370 +10
- Partials 3751 3755 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Collaborator
Author
|
/approve |
apecloud-bot
approved these changes
Sep 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #10832
What this PR does
Completes the restore status aggregation path for workloads using the Instance API:
This restores the expected status flow:
PVC -> Instance -> InstanceSet -> Component -> Cluster
Why
The Instance/InstanceSet v2 path did not publish InstanceRestore conditions. A physical PVC restore could finish while Component and Cluster remained Restore=Unknown, leaving restore intent and protection finalizers behind.
Tests
codex-go-test.sh ./pkg/controller/instance ./pkg/controller/instanceset2 -count=1Dependency
This is a prerequisite for #10777. #10777 should not merge before this fix is in main.