fix: Update Sort on DW Sort class.#686
Merged
Merged
Conversation
Release 0.4.56
Release 0.4.57
Release 0.4.58
ad-claw000
commented
May 20, 2026
Contributor
Author
ad-claw000
left a comment
ad-claw000
left a comment
There was a problem hiding this comment.
Applied autopep8 formatting to the new log messages to fix the pre-commit CI failure.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Sort parameter wrapper to support sorting on multiple properties, so Query can emit a multi-key results.sort specification when needed (fixing #159).
Changes:
- Changed
Sortto internally track multiple sort keys/orders and compute the outgoing sort payload via a property. - Added an
append()method to allow chaining additional sort keys/orders.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
luisremis
approved these changes
May 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updates Sort on DW Sort class to support multiple properties.
Changes
aperturedb/Sort.pyTesting
Tested locally.
Fixes #159