Move generateImage to adb to allow generalized usage - #719
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR relocates the image placeholder generation script from test/ into the aperturedb CLI package and exposes it as a new CLI utility command (adb utils generate-images), aiming to make the generator generally usable beyond tests.
Changes:
- Updated
test/generateInput.pyto importImageGeneratorfromaperturedb.cli.generate_images. - Added a new
adb utils generate-imagesTyper command wired intoaperturedb/cli/utilities.py. - Introduced
aperturedb/cli/generate_images.pycontaining the moved image generation implementation.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| test/generateInput.py | Updates import path to the relocated ImageGenerator. |
| aperturedb/cli/utilities.py | Adds the generate-images CLI command entry point. |
| aperturedb/cli/generate_images.py | Provides the image generation implementation now used by tests and CLI. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…er generate_images module import
ad-claw000
force-pushed
the
fix/issue-267
branch
2 times, most recently
from
May 21, 2026 04:39
6e8010b to
6a94e11
Compare
luisremis
reviewed
May 22, 2026
luisremis
approved these changes
May 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Moved
generateImages.pyfromtest/toaperturedb/cli/generate_images.pyand exposed it viaadb utils generate-images. This allows the script to be used as a generalized tool within the CLI.Verification
python -m aperturedb.cli.adb utils generate-images --helpdisplays the correct options.test/generateInput.pycontinue to function as expected via updated imports.Fixes #267.