fix: resolve conda_gpu tests - #722
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to fix failing conda_gpu CI tests by moving the GPU test Docker base image to Python 3.10 (matching pyproject.toml’s requires-python >=3.10) and re-enabling the conda GPU test job in the PR workflow.
Changes:
- Update
docker/pytorch-gpu/Dockerfileto use a Python 3.10 GPU base image. - Re-add the
run_test_conda_gpuGitHub Actions job to build the GPU test image and execute the containerized test suite.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| docker/pytorch-gpu/Dockerfile | Switches the GPU test container base image to a Python 3.10 variant. |
| .github/workflows/pr.yaml | Restores a PR CI job that builds/runs GPU conda-based tests in a container. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…istry cache importer error
…ng aperturedb dir
ad-claw000
commented
May 22, 2026
ad-claw000
left a comment
ad-claw000
left a comment
Contributor
Author
There was a problem hiding this comment.
I finally fixed the run_test_conda_gpu failure by explicitly installing openai-clip via git directly in the docker/pytorch-gpu/Dockerfile.
luisremis
previously approved these changes
May 22, 2026
luisremis
approved these changes
May 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the underlying issue causing conda_gpu tests to fail by upgrading the docker base image to use Python 3.10.
Verification
Fixes #356.