ci: drop distribution release dispatch - #8500
Merged
Merged
Conversation
The distribution repo is now the installer: its release.yml builds the static binary on its own tag push and has neither a workflow_dispatch trigger nor a `tag` input, so the dispatch failed with HTTP 422 on v4.3.18. The installer resolves api-platform/symfony and api-platform/laravel at install time and pins no core version, so a core tag has nothing to propagate there.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Removes the
dispatch-distribution-updatejob from the release pipeline.Why
The job failed on the v4.3.18 release (run):
api-platform/api-platformis now the installer, and itsrelease.ymlis a different workflow: it ison: push: tags: v*only and builds the static binary (PHAR + micro SAPI, per os/arch). It has noworkflow_dispatchtrigger and notaginput, sogh workflow run -R api-platform/api-platform release.yml -f tag=<tag>cannot succeed.Nothing needs to be re-adapted on the distribution side either: the installer pins no core version.
SymfonyScaffoldrunscomposer require api-platform/symfony api-platform/doctrine-orm …andLaravelScaffoldrunscomposer require api-platform/laravel, both resolved at install time on the user's machine. A core tag has nothing to propagate there.dispatch-demo-updateis untouched —api-platform/demostill hasupgrade-api-platform.ymland that job succeeded in the same run.The job exists on 4.1 through main; landing this on 4.3 and merging up covers the branches that are still tagged.